Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Node version 20+ #2274

Merged
merged 7 commits into from
Apr 20, 2024
Merged

Require Node version 20+ #2274

merged 7 commits into from
Apr 20, 2024

Conversation

Baalekshan
Copy link
Contributor

@Baalekshan Baalekshan commented Apr 20, 2024 •
edited
Loading

Which problem is this PR solving?

#2272

Description of the changes

How was this change tested?

Checklist

@Baalekshan
fix: help with eslint upgrade (jaegertracing#2272)
d9369fb 
Signed-off-by: Baalekshan <baalekshan@gmail.com>
@Baalekshan
fix: help with eslint upgrade (jaegertracing#2272)
1b202bf 
Signed-off-by: Baalekshan <baalekshan@gmail.com>
@Baalekshan
fix: help with eslint upgrade (jaegertracing#2272)
5436b6b 
Signed-off-by: Baalekshan <baalekshan@gmail.com>
@Baalekshan
fix: help with eslint upgrade (jaegertracing#2272)
53348a5 
Signed-off-by: Baalekshan <baalekshan@gmail.com>
@Baalekshan
fix: help with eslint upgrade (jaegertracing#2272)
e01487f 
Signed-off-by: Baalekshan <baalekshan@gmail.com>
@Baalekshan
fix: help with eslint upgrade
b579c86 
Signed-off-by: Baalekshan <baalekshan@gmail.com>
@Baalekshan Baalekshan requested a review from a team as a code owner April 20, 2024 05:57
@Baalekshan Baalekshan requested review from yurishkuro and removed request for a team April 20, 2024 05:57
@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Apr 20, 2024
@yurishkuro yurishkuro changed the title fix: help with eslint upgrade Require Node version 20+ Apr 20, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.59%. Comparing base (c2f4085) to head (68c4f56).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2274   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files         254      254           
  Lines        7641     7641           
  Branches     1992     1977   -15     
=======================================
  Hits         7381     7381           
  Misses        260      260

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Baalekshan
Require Node version 20+
68c4f56 
Signed-off-by: Baalekshan <baalekshan@gmail.com>
yurishkuro
yurishkuro approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro merged commit 13c8591 into jaegertracing:main Apr 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

Assignees
No one assigned
Labels
changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Baalekshan @yurishkuro